Make leap_day=True default for PSM3 (duplicated)#1500
Closed
AdamRJensen wants to merge 4 commits intopvlib:mainfrom
Closed
Make leap_day=True default for PSM3 (duplicated)#1500AdamRJensen wants to merge 4 commits intopvlib:mainfrom
AdamRJensen wants to merge 4 commits intopvlib:mainfrom
Conversation
AdamRJensen
changed the title
This was referenced Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR should first be merged for pvlib 0.11.0!
This PR changes the default value of the
leap_dayparameter inpvlib.iotools.get_psm3from False to True and removes the deprecation warning added in #1511. The reason for the change is that it seems more intuitive to include leap days when requesting non-TMY time series, which is also the default behavior of the remaining iotools functions.