docstring updated to indicate limits of axis_tilt#1489
Merged
kandersolar merged 9 commits intopvlib:masterfrom Jul 19, 2022
kurt-rhee:change_pvlib_tracking_docstring
Merged
docstring updated to indicate limits of axis_tilt#1489kandersolar merged 9 commits intopvlib:masterfrom kurt-rhee:change_pvlib_tracking_docstring
kandersolar merged 9 commits intopvlib:masterfrom
kurt-rhee:change_pvlib_tracking_docstring
Conversation
Member
|
Cool, thanks @kurt-rhee. I think it probably makes sense to make the same comment everywhere the Also please add yourself to the list of contributors in the 0.9.2 what's new file, if you like! |
Contributor
Author
|
@kanderso-nrel Added those additional references when axis_tilt is used as an input and also added myself to the list of contributors. Thanks for the help! |
kandersolar
reviewed
Jul 7, 2022
cwhanse
approved these changes
Jul 7, 2022
Member
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
Some formatting. Thanks @kurt-rhee
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
kandersolar
approved these changes
Jul 7, 2022
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Thanks @kurt-rhee, both for this PR and the discussion over in #1471!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.