clean up 0.8 whatsnew, other minor doc issues#1054
Merged
wholmgren merged 11 commits intopvlib:masterfrom Sep 8, 2020
Merged
Conversation
Closed
Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
Member
Author
|
@cwhanse @mikofski @kanderso-nrel any final edits? I plan to tag 0.8.0 once this is merged. Rendered whats new: https://pvlib-python--1054.org.readthedocs.build/en/1054/whatsnew.html |
Member
|
This bullet in enhancements could be formatted:
I think the arguments should have double backticks and the classes should be linked to module index |
Member
|
Only edit I saw, @mikofski noted. |
Member
Author
|
I should have listened to @kanderso-nrel when he caught that in the PR review. If that's a rule it should be in the Contributing/Documentation section. |
kandersolar
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Please let me know if I've missed any contributors to issue/PR discussions that were closed in this release.