pyupgrade --py36-plus, license year#1050

Merged

mikofski merged 14 commits intopvlib:masterfrom

Sep 6, 2020

Member

wholmgren commented Sep 6, 2020 •

edited

Loading

Closes #xxxx
I am familiar with the contributing guidelines
Tests added
Updates entries to docs/sphinx/source/api.rst for API changes.
Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
Pull request is nearly complete and ready for detailed review.
Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

These changes are the result of the following command:

pyupgrade --py36-plus pvlib/[a-z]*.py pvlib/tests/**/*.py docs/**/*.py

The diff looks good to me except for maybe a couple of minor style issues. Let's see what the full test suite says...

wholmgren added 3 commits

September 6, 2020 12:37


          pyupgrade --py36-plus

707c7db


          update license year

8f6f692


          stickler

d200b49

wholmgren changed the title ~~pyupgrade --py36-plus~~ pyupgrade --py36-plus, license year

wholmgren added this to the 0.8.0 milestone


          test invalid model in irradiance.get_sky_diffuse

5825cc1

Member Author

wholmgren commented Sep 6, 2020

Ok, I believe we can overlook the remaining coverage issues in forecast.py and merge this.

mikofski reviewed

View reviewed changes

pvlib/atmosphere.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

pvlib/location.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

pvlib/modelchain.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

pvlib/modelchain.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

pvlib/pvsystem.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

pvlib/pvsystem.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

pvlib/tests/iotools/test_pvgis.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

pvlib/tracking.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

pvlib/tracking.py Outdated Show resolved Hide resolved

mikofski reviewed

View reviewed changes

Member

mikofski left a comment

Looks great, thanks! I found a few more strings that could be converted to f-strings. Not sure why pyupgrade didn't catch them, but I tested them and they seem to work

Also wasn't sure where test_get_sky_diffuse_invalid came from, seems not related to this pr.

wholmgren and others added 10 commits

September 6, 2020 15:35


          Update pvlib/atmosphere.py

29b9402

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          Update pvlib/location.py

34138d7

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          Update pvlib/modelchain.py

0f79353

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          Update pvlib/modelchain.py

b68f4a5

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          Update pvlib/pvsystem.py

9390e44

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          Update pvlib/pvsystem.py

4a9304b

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          Update pvlib/tests/iotools/test_pvgis.py

9d5112e

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          Update pvlib/tracking.py

2f930ba

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          Update pvlib/tracking.py

68bf730

Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>


          stickler

b67494d

Member Author

wholmgren commented Sep 6, 2020

thanks @mikofski I noticed a couple of those and forgot to go through more carefully.

Also wasn't sure where test_get_sky_diffuse_invalid came from, seems not related to this pr.

A pyupgrade change revealed missing coverage.

mikofski approved these changes

View reviewed changes

Member

mikofski left a comment

Thanks Will! I'm super happy about this PR for some reason. Maybe it's because I ❤️ f-strings?

Member

mikofski commented Sep 6, 2020

okay to merge?

mikofski merged commit 766b0ca into pvlib:master

wholmgren deleted the py36 branch

September 7, 2020 02:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet