Skip to content

add Ross temperature model#1045

Merged
wholmgren merged 9 commits intopvlib:masterfrom
cwhanse:temp_ross
Oct 9, 2020
Merged

add Ross temperature model#1045
wholmgren merged 9 commits intopvlib:masterfrom
cwhanse:temp_ross

Conversation

@cwhanse
Copy link
Member

@cwhanse cwhanse commented Sep 4, 2020 •
edited
Loading

  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

A simple cell temperature model using only NOCT as a parameter.

kandersolar
kandersolar reviewed Sep 19, 2020
View reviewed changes
@cwhanse cwhanse added this to the 0.8.1 milestone Sep 21, 2020
kandersolar
kandersolar approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wholmgren
wholmgren approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Minor stuff below.

wholmgren
wholmgren reviewed Sep 23, 2020
View reviewed changes
@adriesse
Copy link
Member

adriesse commented Sep 23, 2020

Should this really be called a "Ross" model? It's just basic heat loss and NOCT conditions:

total_loss_factor  = 800 / (noct - 20)
heat_input = poa_global
temp_difference = heat_input / total_loss_factor
return temp_air + temp_difference

I wouldn't say this approach ignores the effect of wind but rather that it tacitly assumes a wind speed of 1 m/s.

@cwhanse
Copy link
Member Author

cwhanse commented Sep 23, 2020

Should this really be called a "Ross" model? It's just basic heat loss and NOCT conditions:

Agree that's what it is, but it needs a name, and others have cited it as Ross' model (author of the reference).

I wouldn't say this approach ignores the effect of wind but rather that it tacitly assumes a wind speed of 1 m/s.

good point.

cwhanse
cwhanse commented Oct 5, 2020
View reviewed changes
Copy link
Member Author

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change docstring

@wholmgren
Copy link
Member

wholmgren commented Oct 9, 2020

thanks @cwhanse!

@wholmgren wholmgren merged commit b105021 into pvlib:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wholmgren wholmgren wholmgren approved these changes

@kandersolar kandersolar kandersolar approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

0.8.1

Development

Successfully merging this pull request may close these issues.

4 participants

@cwhanse @adriesse @wholmgren @kandersolar