fix github action for publishing releases#1039
Merged
wholmgren merged 2 commits intopvlib:masterfrom Sep 1, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1038 didn't work because pypi (and test pypi) don't allow local versions (tag+commits.hash). With some work (e.g. here) it would be possible to upload distributions for each commit to test pypi, but I don't think it's worth the effort. So this PR simplifies the build to tags that start with "v" and only pushes to pypi.
I don't understand why the PyPA guide suggests uploading each commit to test pypi if the standard tools don't make it easy to do so. I checked a hadnful of PyPA's own packages and none of them follow this practice either.
Once this PR is merged I'll test it by pushing an 0.8.0 alpha tag.