Fix problems with different hash values for str and bytes

hyperbora · hyperbora · commit e7eab050f4c2 · 2020-08-09T16:09:46.000+09:00
diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
@@ -691,8 +691,6 @@ def __getattr__(self, what):
                 raise ValueError
         self.assertRaises(ValueError, hasattr, B(), "b")
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_hash(self):
         hash(None)
         self.assertEqual(hash(1), hash(1))
diff --git a/common/src/hash.rs b/common/src/hash.rs
@@ -118,5 +118,5 @@ pub fn hash_bigint(value: &BigInt) -> PyHash {
 }
 
 pub fn hash_str(value: &str) -> PyHash {
-    hash_value(value)
+    hash_value(value.as_bytes())
 }

Original file line number	Diff line number	Diff line change
`@@ -118,5 +118,5 @@ pub fn hash_bigint(value: &BigInt) -> PyHash {`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`pub fn hash_str(value: &str) -> PyHash {`
`121`		`- hash_value(value)`
	`121`	`+ hash_value(value.as_bytes())`
`122`	`122`	`}`