Update library to compile on upcoming 0.14.0 PureScript release#26
Merged
athanclark merged 1 commit intopurescript-contrib:polykindsupdatefrom Feb 14, 2020
JordanMartinez:polykindsUpdate
Merged
Update library to compile on upcoming 0.14.0 PureScript release#26athanclark merged 1 commit intopurescript-contrib:polykindsupdatefrom JordanMartinez:polykindsUpdate
athanclark merged 1 commit intopurescript-contrib:polykindsupdatefrom
JordanMartinez:polykindsUpdate
Conversation
athanclark
approved these changes
Feb 13, 2020
Collaborator
athanclark
left a comment
athanclark
left a comment
There was a problem hiding this comment.
Looks good; but I don't feel comfortable merging into master until the 0.14.0 version is released. I'll merge these into a separate branch for now until then, though!
Contributor
Author
|
Yeah don't merge until the next PureScript release. You might also need to
update things in the test folder.
You could follow what we did in the core libraries and create a branch for
the upcoming release and switch this PR to target that one and then merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context, see https://discourse.purescript.org/t/updating-the-ecosystem-for-upcoming-0-14-0-release/1144