feat(client): add social metas#115
Merged
hdgarrood merged 3 commits intopurescript:gh-pagesfrom Jan 1, 2020
Merged
Conversation
paf31
reviewed
Dec 11, 2017
index.html
Outdated
| <meta property="og:type" content="website"> | ||
| <meta property="og:url" content="http://try.purescript.org/"> | ||
| <meta property="og:title" content="Try PureScript!"> | ||
| <meta property="og:image" content="https://raw.githubusercontent.com/purescript/logo/master/youtube/channel_icon-800.png"> |
Contributor
There was a problem hiding this comment.
Maybe we should copy this image into this repo?
Contributor
Author
There was a problem hiding this comment.
Done. 🙌
Note: The
twitter:imageproperty do not support relative paths.
Contributor
|
Great, thanks! |
paf31
reviewed
Dec 12, 2017
index.html
Outdated
| <meta property="og:type" content="website"> | ||
| <meta property="og:url" content="http://try.purescript.org/"> | ||
| <meta property="og:title" content="Try PureScript!"> | ||
| <meta property="og:image" content="http://try.purescript.org/img/channel_icon-800.png"> |
Contributor
There was a problem hiding this comment.
One last thing - could you please add an attribution notice in a comment here? Something like
<!--
The PureScript Logo by Gareth Hughes is licensed under the Creative Commons Attribution 4.0 license (https://creativecommons.org/licenses/by/4.0/).
-->Thanks!
Contributor
There was a problem hiding this comment.
Or maybe you could use og:image:alt and twitter:image:alt.
Contributor
Author
There was a problem hiding this comment.
Sure, we should add this information!
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add metas to fix something like: