add getter for error's name when available#24
Merged
paf31 merged 1 commit intopurescript:masterfrom Jul 27, 2017
Merged
Conversation
Contributor
|
Looks good, but Maybe something like "Unknown error", what do you think? |
Contributor
Author
|
Well, I have picked "Error" exactly for that purpose. Here's my rational: (Almost) any type can be thrown in JavaScript; yet it's not the case in PureScript (so far). Therefore every error which is going to be manipulated from PureScript is actually going to be an instance of Error. Hence the default. |
Contributor
|
@garyb Any thoughts before I merge this one? |
Member
|
Looks fine to me, I think |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks!
I've added a small accessor which retrieves the
nameof an error when available. The property is specified by the ECMAScript spec 5.1 and is quite useful to perform pattern matching in a relatively reliable way.In some cases and for some browsers though, the property
nameremains undefined in which case I chose to fallback to the initial name of 'Error' (instead of going for aError -> Maybe Stringas I find the former approach more practical).Let me know 👍