rethrow: throw a new, modified version of an exception#22
Closed
matthewleon wants to merge 3 commits intopurescript:masterfrom
Closed
rethrow: throw a new, modified version of an exception#22matthewleon wants to merge 3 commits intopurescript:masterfrom
matthewleon wants to merge 3 commits intopurescript:masterfrom
Conversation
hdgarrood
reviewed
Jun 1, 2017
Contributor
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Looks good to me! I think the doc comment could be clarified a little though - maybe something more like "if an exception is thrown, ..." so that it's clear what happens if the action doesn't throw?
Author
Good catch. I think the new one is clearer. |
Author
|
this is probably superseded by #26 |
Contributor
|
Yes, I think you're right. Thanks anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems quite important to have something like this, which I was sadly unable to achieve without cheating the type system a bit.
If someone knows of a way to kill off the coercion, I'd be very happy to do so!