Derive Generic instance for Either#57
Closed
paulyoung wants to merge 1 commit intopurescript:masterfrom
Closed
Conversation
This was referenced Oct 22, 2020
Contributor
|
This one does still apply:
|
Contributor
Author
|
@garyb had a suggestion along those lines here: purescript-deprecated/purescript-generics-rep#43 (comment) |
| "purescript-bifunctors": "master", | ||
| "purescript-control": "master", | ||
| "purescript-foldable-traversable": "master", | ||
| "purescript-generics-rep": "master", |
Contributor
There was a problem hiding this comment.
We'll be moving the generics-rep repo's code into prelude, so we can drop the dependency on generics-rep.
57 tasks
Contributor
|
Superceded by #61, which builds off this PR but removes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
purescript-deprecated/purescript-generics-rep#34 (comment) says:
I'm not sure if the concerns expressed in that other PR apply here.