Fix typechecking of constrained type values#951
Merged
Conversation
Contributor
|
Looks good, thanks for taking a look at this. The CI build should run the core libs, but it might be worth running 🚢 |
garyb
added a commit
that referenced
this pull request
Mar 8, 2015
Fix typechecking of constrained type values
Member
|
Cool! That probably fixes that tuple issue in lens. I'll check when the next release is made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned at the end of #928, see new test for an example - previously
sequenceArray''andsequenceArray'''would not pass typechecking.