Conversation
There was a problem hiding this comment.
Perhaps should name this something other than parseIdentInfix, and update the hint for parsec?
|
Looks good to me apart from that minor nitpick :) Will be interesting to see how this pans out. Just because it can be abused doesn't necessarily seem like a reason not to have it either. 👍 |
|
I overhauled the syntax guide this morning by the way (I know we promote the book over that stuff now, but it's still valuable as a quick reference I think) so you might want to update that after releasing this too. |
|
Oh, and you might want to tweak the pretty printer for |
|
All good points, thank you. |
There was a problem hiding this comment.
This is really nice and has great readability -- also easier to explain the `` rule as operating over expressions as opposed to just "identifiers". It would be useful to put a nested example in these tests to demonstrate the parser can handle nesting.
There was a problem hiding this comment.
Sure thing. Will be nice to get the coverage up as well.
4 participants
@garyb Could you please review this one?