Conversation
…ectory for prelude. Fix #657.
|
Looks good to me, will have to update the Grunt and Gulp plugins for the docgen changes after this is merged/released though. |
|
Yeah, I can take that change out if it's too much. I know we discussed renaming it a while ago, and I figure it's better to do it before 0.6 than after. |
|
Yeah, the renaming will break those two things, and probably anyone's make files (if they're using docgen). Looks good to me though. |
|
So shall I revert the docgen change for now? |
|
I think it's fine. It could be transparent to most of us. Who uses a makefile? @michaelficarra I think does for a few projects. I'm not sure who else. |
|
Agreed, since we're going to break it at some point sooner is probably better than later. We can update the tasks to keep the |
|
The renaming shouldn't be a problem for |
|
Shall I merge this then? |
|
I've updated my Makefile in the commit linked above (78547152). The only other PureScript user that uses a Makefile that I know of is @davidchambers. |
|
👍 for merge |
Rename docgen, remove installation script, update license, change direct...
There was a problem hiding this comment.
This still mentions docgen. Should it be psc-docs instead?
edit: Opened up a PR: #675
|
FYI, @bodil has a PureScript build tool named "pulp". I've opened an issue to address this change: purescript-contrib/pulp#6. |
...ory for prelude. Fix #657.
@garyb @joneshf Could you please review?