Skip to content

Rename docgen, remove installation script, update license, change direct...#670

Merged
paf31 merged 1 commit intomasterfrom
657
Nov 3, 2014
Merged

Rename docgen, remove installation script, update license, change direct...#670
paf31 merged 1 commit intomasterfrom
657

Conversation

@paf31
Copy link
Copy Markdown
Contributor

@paf31 paf31 commented Nov 3, 2014

...ory for prelude. Fix #657.

@garyb @joneshf Could you please review?

@garyb
Copy link
Copy Markdown
Member

garyb commented Nov 3, 2014

Looks good to me, will have to update the Grunt and Gulp plugins for the docgen changes after this is merged/released though.

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Nov 3, 2014

Yeah, I can take that change out if it's too much. I know we discussed renaming it a while ago, and I figure it's better to do it before 0.6 than after.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) when pulling a979da1 on 657 into af0492a on master.

@joneshf
Copy link
Copy Markdown
Member

joneshf commented Nov 3, 2014

Yeah, the renaming will break those two things, and probably anyone's make files (if they're using docgen). Looks good to me though.

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Nov 3, 2014

So shall I revert the docgen change for now?

@joneshf
Copy link
Copy Markdown
Member

joneshf commented Nov 3, 2014

I think it's fine. It could be transparent to most of us. {grunt,gulp}-purescript could maintain backwards compatibility for a few versions with an alias. Or, just break backwards compatibility (I don't think it makes that much of a difference). @ethul @garyb thoughts?

Who uses a makefile? @michaelficarra I think does for a few projects. I'm not sure who else.

@garyb
Copy link
Copy Markdown
Member

garyb commented Nov 3, 2014

Agreed, since we're going to break it at some point sooner is probably better than later. We can update the tasks to keep the docgen name as an alias with a deprecation warning, and shouldn't be too much trouble to use either psc-docs or docgen depending on which is present.

@ethul
Copy link
Copy Markdown

ethul commented Nov 3, 2014

The renaming shouldn't be a problem for gulp-purescript.

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Nov 3, 2014

Shall I merge this then?

@michaelficarra
Copy link
Copy Markdown
Contributor

I've updated my Makefile in the commit linked above (78547152). The only other PureScript user that uses a Makefile that I know of is @davidchambers.

@garyb
Copy link
Copy Markdown
Member

garyb commented Nov 3, 2014

👍 for merge

paf31 added a commit that referenced this pull request Nov 3, 2014
Rename docgen, remove installation script, update license, change direct...
@paf31 paf31 merged commit ca7bc0a into master Nov 3, 2014
@paf31 paf31 deleted the 657 branch November 3, 2014 21:20
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still mentions docgen. Should it be psc-docs instead?

edit: Opened up a PR: #675

@michaelficarra
Copy link
Copy Markdown
Contributor

FYI, @bodil has a PureScript build tool named "pulp". I've opened an issue to address this change: purescript-contrib/pulp#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install.sh creates /usr/local/purescript?

6 participants