Skip to content

Fix various bugs, add support for multiple errors#601

Merged
paf31 merged 6 commits intomasterfrom
flight_work
Sep 19, 2014
Merged

Fix various bugs, add support for multiple errors#601
paf31 merged 6 commits intomasterfrom
flight_work

Conversation

@paf31
Copy link
Copy Markdown
Contributor

@paf31 paf31 commented Sep 17, 2014

@garyb @joneshf Mind having a look? This is a bunch of work from on a flight, which is why it's quite poorly organized, sorry. If you look at the individual commits, it should make more sense.

Thanks,

@garyb
Copy link
Copy Markdown
Member

garyb commented Sep 17, 2014

Hah, awesome. 👍

I'm not sure I quite understand the fix for #600, but then I didn't entirely understand what was causing the bug either. I'll figure it out, but if all the tests still pass, etc. I'm sure it's fine anyway.

I guess I might need to do some additional stuff in Names for #524 too.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) when pulling 51914cc on flight_work into 1bf7686 on master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.09%) when pulling d1cdc98 on flight_work into 1bf7686 on master.

@paf31
Copy link
Copy Markdown
Contributor Author

paf31 commented Sep 19, 2014

@garyb Ok to merge this one then?

@garyb
Copy link
Copy Markdown
Member

garyb commented Sep 19, 2014

Yep, think so 👍

paf31 added a commit that referenced this pull request Sep 19, 2014
Fix various bugs, add support for multiple errors
@paf31 paf31 merged commit caa1dc6 into master Sep 19, 2014
@paf31 paf31 deleted the flight_work branch September 19, 2014 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants