Conversation
|
As the comment in the file you changed says, we'll need to bump the docker image for CI as well |
|
As a matter of policy, we don't do unmotivated version bumps; a |
|
@rhendric that's not my experience that stack needs to blow away it's cache. You can try it yourself just start a new haskell project with stack and then change the resolver to some different LTS. Builds already done on a particular LTS will build fast. Do you have a test case to reproduce your scenario where stack throws away the cache? |
|
Uh, new compiler means new compilation artifacts; there's no test case involved here, that's just how it works. Do you have a motivation for this or not? |
|
@rhendric yes new compiler, new artifacts. That doesn't explain what you were saying about stack blowing away cache and git bisect. The motivation is that purescript is now on a compiler from 2022 that's a year ago. Every year the 9.2.5 version will get a year older. Meanwhile improvements are made to GHC which purescript can not benefit from as long as it's stuck on 9.2.5. How many years would you wait before updating a dependency? |
Right, so in a year or two when developers are on whatever the current GHC is, hunting down a regression with
On this project, indefinitely, unless something can't be supported anymore, there's a bug needs fixing, we want a feature from a newer version, or there's a measured performance improvement from which we want to benefit (or similar motivations; this isn't necessarily an exhaustive list). Otherwise, if it isn't broken, we don't fix it. |
|
Thanks Ryan! |
|
Looking at the reasons not to do it: First issue #4449 Second issue #3990
For the bisect you would need somebody who only caches for the purescript project as caches are shared between all your haskell projects. And also needs to do a bisect that spans over 2 years. And also has not done a bisect recently. And then this waiting time is incured only ones until the next active removal of the cache (like an OS install). Looking at the reasons to do it: These are the improvements to be had for upgrading the GHC version:
There could be further improvements in packages but i didn't look into that. If it ain't broke, don't fix it is often with an implication that the attempted improvement is risky and might backfire. But no possible risks were stated. Backfiring is an overstatement on a one-off cache rebuild imo. |
|
@flip111, I appreciate your willingness to get involved in PureScript's development. We aren't interested in this sort of contribution unless the version bump contributes to another goal. But if you would like to make a future contribution that fixes a bug or implements a feature, I look forward to reviewing and eventually merging it. Please let this PR be. |
Only a minimal change was required to update the GHC version. Changed the version of
happyfrom1.20.0to1.20.1.1.From: LTS Haskell 20.9 (ghc-9.2.5) Published on 2023-01-28
To: LTS Haskell 20.26 (ghc-9.2.8) Published on 2023-06-18