Skip to content

Upgrade to GHC 9.2.7#4449

Closed
Unisay wants to merge 1 commit intopurescript:masterfrom
Unisay:update-ghc-9.2.7
Closed

Upgrade to GHC 9.2.7#4449
Unisay wants to merge 1 commit intopurescript:masterfrom
Unisay:update-ghc-9.2.7

Conversation

@Unisay
Copy link
Copy Markdown

@Unisay Unisay commented Mar 8, 2023

Description of the change

Updates GHC to 9.2.7 and the Stackage snapshot to LTS-20.13.

The changes are very similar to the #4433.


Checklist:

  • Added a file to CHANGELOG.d for this PR (see CHANGELOG.d/README.md)
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@rhendric
Copy link
Copy Markdown
Member

rhendric commented Mar 8, 2023

This PR contains several unrelated zero-impact formatting changes; please remove them.

More generally, why are we following point releases of GHC like this? I can understand doing major version bumps to keep up with the times, and the occasional minor bump to get an important feature or compatibility with an LTS snapshot or something, but I don't want to do this every month if we don't have a reason to.

@Unisay Unisay force-pushed the update-ghc-9.2.7 branch 2 times, most recently from 74c3fd5 to c3b78d7 Compare March 8, 2023 22:02
@Unisay Unisay force-pushed the update-ghc-9.2.7 branch from c3b78d7 to 502d405 Compare March 9, 2023 07:56
@Unisay
Copy link
Copy Markdown
Author

Unisay commented Mar 9, 2023

This PR contains several unrelated zero-impact formatting changes; please remove them.

Sure. I have removed all unintentional formatting changes already (vscode did them automatically without asking me, bad boy).

More generally, why are we following point releases of GHC like this?

Idk about any existing conventions. The previous bump wasn't a major one and it let me to believe that this is the way.

I can understand doing major version bumps to keep up with the times, and the occasional minor bump to get an important feature or compatibility with an LTS snapshot or something, but I don't want to do this every month if we don't have a reason to.

I respect your time and effort, and will follow any guideline you decide to come up with. I'd also appreciate if a decision criteria are not subjective (e.g. an "importance of a certain feature or compatibility" is usually a relative measure).

Please close this PR if you feel like its not worth your time reviewing and answering it.

Thank you!

@purefunctor
Copy link
Copy Markdown
Member

The previous bump was made as we were previously on a nightly package set and a GHC version that wasn't supported by HLS (if I recall correctly, at least). Like mentioned, unless there's a super important bugfix or if some incompatibility, keeping up with minor releases can become a bit tedious.

Moving forward, I think we can mark this PR as a WIP until we find the need to bump the minor version or it gets superseded by another version bump.

@wclr
Copy link
Copy Markdown
Contributor

wclr commented Mar 12, 2023

Btw, GHC 9.2.7 is not on the list of supported versions by HLS.

@JordanMartinez
Copy link
Copy Markdown
Contributor

Closing as this doesn't seem like we'll be merging.

@rhendric rhendric mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants