Skip to content

Depend on hspec-2.10.9#4435

Merged
rhendric merged 2 commits intopurescript:masterfrom
sol:patch-2
Feb 4, 2023
Merged

Depend on hspec-2.10.9#4435
rhendric merged 2 commits intopurescript:masterfrom
sol:patch-2

Conversation

@sol
Copy link
Copy Markdown
Contributor

@sol sol commented Feb 1, 2023 •
edited
Loading

This addresses hspec/hspec#685 (comment)

@sol sol mentioned this pull request Feb 1, 2023
Closed
sol
sol commented Feb 1, 2023
View reviewed changes
purescript.cabal
purescript,
generic-random >=1.5.0.1 && <1.6,
hspec ==2.9.2,
hspec >= 2.10.7 && < 3,
Copy link
Copy Markdown
Contributor Author

@sol sol Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test.Hspec is committed to be stable. Unless you rely on internal particulars of hspec-core, any recent version of Hspec will work.

@sol sol changed the title Update stack.yaml Depends on hspec-2.10.9 Feb 1, 2023
@sol sol changed the title Depends on hspec-2.10.9 Depend on hspec-2.10.9 Feb 1, 2023
@andys8
Copy link
Copy Markdown
Contributor

andys8 commented Feb 1, 2023

I don't fully understand this being a fix for the terminfo issue. Judging from the comment I assumed 2.9.3 introduced a dependency and we're therefore stuck with 2.9.2. Is it now just fine to update? Or is this not the case anymore in 2.10.9?

purescript/stack.yaml

Lines 23 to 29 in 3cf7393

# hspec@2.9.3 is the first version that starts depending on ghc
# ghc depends on terminfo by default, but that can be ignored
# if one uses the '-terminfo' flag.
# Unfortunately, hspec doesn't expose a similar flag.
- hspec-2.9.2
- hspec-core-2.9.2
- hspec-discover-2.9.2

@sol
Copy link
Copy Markdown
Contributor Author

sol commented Feb 1, 2023

Or is this not the case anymore in 2.10.9?

Yes, it's not. I intended to reflect that in the updated comment.

Here is the related changelog entry: https://github.com/hspec/hspec/blob/main/CHANGES.markdown#changes-in-2107-2022-12-03

@andys8
Copy link
Copy Markdown
Contributor

andys8 commented Feb 1, 2023

Ah, I didn't catch the changed comment. Cool, thanks.

@rhendric
Copy link
Copy Markdown
Member

rhendric commented Feb 1, 2023

Build failure is connected to purescript/registry#170; this PR is blameless.

@andys8 andys8 mentioned this pull request Feb 1, 2023
Merged
5 tasks
@rhendric rhendric merged commit 4cdf6df into purescript:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhendric rhendric rhendric approved these changes

@f-f f-f f-f approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sol @andys8 @rhendric @f-f