Bump HLint to version 3.5 and address most of the new hints#4391
Bump HLint to version 3.5 and address most of the new hints#4391JordanMartinez merged 8 commits intopurescript:masterfrom
Conversation
|
Oh, hi glibc hell. The newest HLint binary that doesn't have a glibc 2.27 dependency seems to be 3.3.1, but that version doesn't parse some stuff I'm working on and so I'd rather use 3.5 if we can. [Edit: Got it, just switched back to the official image for the lint job only and that did the trick.] Once I do get this working... as we did in #4090, probably best to merge this with a traditional merge commit instead of squashing, so that individual hints can be backed out if we change our mind about any of them. |
rhendric
force-pushed
the
rhendric/bump-hlint
branch
from
7b7828d to
ffabc64
Compare
| - ignore: {name: "Avoid lambda using `infix`"} | ||
| - ignore: {name: "Fuse mapM/map"} | ||
| - ignore: {name: "Eta reduce"} # This warning will often make suggestions that are no longer valid due to simplified subsumption | ||
| - ignore: {name: "Redundant <$>"} |
There was a problem hiding this comment.
If I understand correctly, this is included for better clarity on the AST traversals, right?
|
After this was merged, the linting workflow seems to complain about: Any clues as to why? I was guessing this is because of the |
3 participants
Description of the change
Fixes #4385.
Checklist: