Increase rendered typed holes to max of 30#4341
Increase rendered typed holes to max of 30#4341JordanMartinez merged 1 commit intopurescript:masterfrom JordanMartinez:jam/increase-hole-amounts
Conversation
rhendric
left a comment
There was a problem hiding this comment.
I suppose the best way to have an actual conversation about a number this arbitrary and unexciting is to change it and see who complains!
|
One thing I'm not aware of is whether the size of the list that's forced contributes to how much work is done to compute it. That is, it's already pretty slow at 5 items. Does changing it to 30 or whatever increase the work significantly (ie. is the list produced lazily)? If the same work is done regardless, then it doesn't really matter. |
|
The list ultimately comes from purescript/src/Language/PureScript/TypeChecker/Monad.hs Lines 314 to 318 in 3c28f9c Clearly some work is saved by truncating that list but the only meaningful source of laziness I see here is if |
|
What would be a good way to confirm whether this adds a lot of work or not? |
|
One way we could test this is do a prerelease and see what people find in their usage of it. It's not hard to change this back to 5 (or some other higher-than-5 number). This is also not a breaking change, so we can adjust this as needed. |
|
I think trialing this for 0.15.3 would be fine. |
|
Part of me wonder if this should be merged as the first Alternatively, this could get merged and |
|
With |
Description of the change
Fixes #4340
Checklist: