Remove purs bundle and browser backend for purs repl#4255
Remove purs bundle and browser backend for purs repl#4255JordanMartinez merged 19 commits intopurescript:masterfrom JordanMartinez:remove-purs-bundle
purs bundle and browser backend for purs repl#4255Conversation
|
Purs bundle should fail with a link to some sort of documentation with alternatives. |
Ideally, that would be the migration guide's corresponding section: https://github.com/purescript/documentation/blob/master/migration-guides/0.15-Migration-Guide.md#how-can-i-bundle-my-library-or-application Not sure if that header will change between now and the release. |
|
Lint error is caused by Should we drop that? Comment it out? I'm not sure how often we'll be using that instead of |
Use writeUTF8FileT instead
I vote drop it. Commenting it out is worse than adding it as a Weeder root; it would just be a breeding ground for bitrot. And we should encourage new code to use |
purs bundlepurs bundle and browser backend for purs repl
|
FYI, there's some machinery in TestUtils.hs for handling the RerunCompilerTests.txt file that I think you can rip out along with said file; I believe it was only ever used for bundler tests. |
|
Yeah, looks like it was only used with |
|
One comment raised when I talked about this in the recent ES modules Discord call is whether this PR also removes any "dead dependencies." For example, do we still need dependencies for web server-related functionality that enabled the REPL browser backend? I'd guess not, but I'm not sure which dependencies these would be. |
My guess is that it would be these: https://github.com/JordanMartinez/purescript/blob/remove-purs-bundle/purescript.cabal#L339-L342 Also I think |
Co-authored-by: Thomas Honeyman <hello@thomashoneyman.com>
Yup, spot on! |
Description of the change
Fixes #4226. Also fixes #4252 because the browser backend for the repl depends on
purs bundleworking. This is a WIP.I wasn't sure whether we want to keep
purs bundleand just throw an error (current PR) or to remove the command completely.Checklist: