Update CI to use windows-2019#4248
Update CI to use windows-2019#4248JordanMartinez merged 1 commit intopurescript:masterfrom JordanMartinez:update-ci-windows
windows-2019#4248Conversation
|
Yeah, it's not a breaking change from a you-can-always-build-from-source perspective, but we seem to have a set of users who can't/won't do that, and for them, changing how the binaries get built can be breaking—at least on Linux, it motivated the whole conversation in #4107. I don't know if bumping the Windows build environment can have the same impact, but I tagged the issue as breaking thinking maybe better safe than sorry. OTOH, @hdgarrood agreed with you on not marking this sort of thing as breaking in the changelog. I'm not convinced that policy best serves those aforementioned users, but given that this is a Windows-only change it's probably a moot point either way? |
|
Perhaps it should be mentioned in the Discourse announcement for Windows users? |
Description of the change
Fixes #4242
I've listed the changelog entry as 'internal' as I'm not quite sure how this is a "breaking change" to end-users. CI does build our binaries, so perhaps that can affect things?
Checklist: