Skip to content

Make v0.14.6 PS release#4236

Merged
JordanMartinez merged 14 commits intopurescript:masterfrom
JordanMartinez:make-0.14.6
Feb 25, 2022
Merged

Make v0.14.6 PS release#4236
JordanMartinez merged 14 commits intopurescript:masterfrom
JordanMartinez:make-0.14.6

Conversation

@JordanMartinez
Copy link
Copy Markdown
Contributor

Description of the change

Prep PR for making the v0.14.6 release


Checklist:

  • Added a file to CHANGELOG.d for this PR (see CHANGELOG.d/README.md)
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez marked this pull request as ready for review February 18, 2022 21:24
@JordanMartinez
Copy link
Copy Markdown
Contributor Author

Now that #4217 has been merged, should release guide be updated to remove the instructions specifying that?

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

CI is failing because we build the package set to verify no breaking changes were introduced in a PR. Unfortunately, it means the metadata package causes the build to fail. I'm looking into it.

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

To fix CI, it looks like we need to make an empty commit in spacchetti/purescript-metadata and add a tag for it. Since that affects package sets, I'm not sure if that triggers anything else. @f-f Could you clarify what that will do?

@JordanMartinez JordanMartinez mentioned this pull request Feb 21, 2022
5 tasks
@JordanMartinez
Copy link
Copy Markdown
Contributor Author

I need one approval before I can merge this and make the next release.

@f-f
Copy link
Copy Markdown
Member

f-f commented Feb 22, 2022

Could you clarify what that will do?

@JordanMartinez the metadata package is a giant hack so that we can keep track of purs' version inside package sets. The reason why this hack exists is that we can't change package sets' format due to keeping compatibility with psc-package, and getting rid of this hack is one of the reasons why I'm restructuring Spago's config format.

I can cut a new release of that so you don't need to depend on a fork here in this PR

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

@f-f I'd appreciate the new release. Thanks!

@f-f
Copy link
Copy Markdown
Member

f-f commented Feb 22, 2022

@JordanMartinez done!

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

Thanks!

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

Can I get an approval here?

@thomashoneyman
Copy link
Copy Markdown
Member

@JordanMartinez I'm almost done with #4233; would you mind delaying this until Friday so this has a chance to go in first? If not, I can try to work it in to a 0.14.7 release instead.

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

@thomashoneyman Fine by me! But if it's delayed beyond Friday, then I will release this (so long as I get an approval).

@thomashoneyman
Copy link
Copy Markdown
Member

Just waiting on reviews at this point, but the PR is complete.

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

I've updated this PR to account for the purs publish PR (#4233). Once CI builds, this just needs an approval, and then I can release it.

@JordanMartinez JordanMartinez merged commit a102390 into purescript:master Feb 25, 2022
@JordanMartinez JordanMartinez deleted the make-0.14.6 branch February 25, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants