Build the entire latest package set in CI#4217
Merged
JordanMartinez merged 2 commits intopurescript:masterfrom Dec 21, 2021
Merged
Build the entire latest package set in CI#4217JordanMartinez merged 2 commits intopurescript:masterfrom
JordanMartinez merged 2 commits intopurescript:masterfrom
Conversation
rhendric
force-pushed
the
rhendric/build-package-set
branch
from
3b93f32 to
51378e9
Compare
rhendric
force-pushed
the
rhendric/build-package-set
branch
2 times, most recently
from
808b060 to
4b73310
Compare
The package set is only built in Linux, as that tends to be the OS that otherwise finishes first, and there's no need to run this test three times. The package set is *not* built if there are any files in CHANGELOG.d starting with `breaking_`, indicating that there are unreleased breaking changes.
rhendric
force-pushed
the
rhendric/build-package-set
branch
from
4b73310 to
9a01dd5
Compare
JordanMartinez
approved these changes
Dec 21, 2021
Contributor
JordanMartinez
left a comment
JordanMartinez
left a comment
There was a problem hiding this comment.
LGTM! While I think we should provide a better solution to #4072 than what we're currently doing, it should be handled in a separate PR.
f-f
approved these changes
Dec 21, 2021
Member
f-f
left a comment
f-f
left a comment
There was a problem hiding this comment.
This looks great, thanks @JordanMartinez and @rhendric!
3 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package set is only built in Linux, as that tends to be the OS that
otherwise finishes first, and there's no need to run this test three
times. The package set is not built if there are any files in
CHANGELOG.d starting with
breaking_, indicating that there areunreleased breaking changes.
Description of the change
Building from the path @JordanMartinez blazed in #4165; the main differences in approach here are not worrying about splitting this step into its own job (it looked like that was going to make CI both take longer and be more complex), and using the presence of
CHANGELOG.d/breaking_*files to bail out. Let's see if I have any more luck....Checklist:
Added myself to CONTRIBUTORS.md (if this is my first contribution)Added a test for the contribution (if applicable)