Add a hint for errors in foreign data type declarations#4161
Merged
JordanMartinez merged 2 commits intopurescript:masterfrom Jul 17, 2021
Merged
Add a hint for errors in foreign data type declarations#4161JordanMartinez merged 2 commits intopurescript:masterfrom
JordanMartinez merged 2 commits intopurescript:masterfrom
Conversation
natefaubion
approved these changes
Jul 17, 2021
rhendric
approved these changes
Jul 17, 2021
JordanMartinez
approved these changes
Jul 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
While adding a hint category for declarations in #4157 I noticed that foreign data type declarations, unlike foreign imports, don’t have such hint already. This seems to be an oversight.
Checklist:
Added myself to CONTRIBUTORS.md (if this is my first contribution)Linked any existing issues or proposals that this pull request should closeUpdated or added relevant documentation