Desugar type class instance names in type class desugaring pass#4099
Merged
JordanMartinez merged 1 commit intopurescript:masterfrom Jun 21, 2021
JordanMartinez:inlineTCInstanceNamesDesugaringPass
Merged
Desugar type class instance names in type class desugaring pass#4099JordanMartinez merged 1 commit intopurescript:masterfrom JordanMartinez:inlineTCInstanceNamesDesugaringPass
JordanMartinez merged 1 commit intopurescript:masterfrom
JordanMartinez:inlineTCInstanceNamesDesugaringPass
Conversation
JordanMartinez
commented
Jun 2, 2021
triallax
reviewed
Jun 2, 2021
Contributor
Author
|
I took this PR, ran Everything compiled fine without issue. I then ran |
5 tasks
Contributor
Author
|
I've updated this PR to build on top of master now that #4096 has been merged |
hdgarrood
approved these changes
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR makes the changes I described in #4085 about inlining the type class instance name desugar pass into the type classes desugar pass.
Since I assume #4096 will get merged, which would introduce merge conflicts, I built this PR on top of #4096 to better demonstrate this minor fix. See the third commit (and following if changes are requested).Once #4096 does get merged#4096 has been merged. This PR will need to be rebased to fix the merge conflict. Until then I won't add an entry for the changelog.Checklist: