Remove unused Data.Foldable.foldr import#4042
Merged
JordanMartinez merged 2 commits intopurescript:masterfrom Apr 3, 2021
Merged
Remove unused Data.Foldable.foldr import#4042JordanMartinez merged 2 commits intopurescript:masterfrom
JordanMartinez merged 2 commits intopurescript:masterfrom
Conversation
JordanMartinez
approved these changes
Apr 3, 2021
rhendric
approved these changes
Apr 3, 2021
Member
rhendric
left a comment
rhendric
left a comment
There was a problem hiding this comment.
Should this even be mentioned in the changelog at all? Otherwise, 
.
Contributor
|
Yeah, I think it should. It provides accountability as to what changed. Besides, it's easier to remove unneeded things before making a release than it is to remember what to add. |
Contributor
|
I don’t think we need accountability here and I’m not sure a strict policy of having every change noted in the changelog is a good way of achieving that anyway. We already have the git history for cases where we want to be able to look at every change and who made it don’t we? It probably doesn’t matter now but I think this could have been left out. |
Member
Author
|
Duly noted! We can clean the changelog when releasing the next minor version. |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
We added an import for
Data.Foldable.foldrtoLanguage.PureScript.CoreImp.Optimizer.TCOin #3958. The build passed (https://travis-ci.org/github/purescript/purescript/builds/763606846) but subsequent builds started to fail with “The import of ‘Data.Foldable’ is redundant” since we merged #4013. The latter upgradedbase-compatand GHC butbase-compat-0.10.5already exportedPrelude.Compat.foldr, and according to GHC documentation-Wunused-importswas already implied by -Wall in v8.6.5 so I really don’t understand what’s going on 🤷♂️Checklist: