Skip to content

Updates for GHC 8.10.4#4013

Merged
hdgarrood merged 4 commits intopurescript:masterfrom
kritzcreek:ghc-8.10.3
Mar 20, 2021
Merged

Updates for GHC 8.10.4#4013
hdgarrood merged 4 commits intopurescript:masterfrom
kritzcreek:ghc-8.10.3

Conversation

@kritzcreek
Copy link
Copy Markdown
Member

@kritzcreek kritzcreek commented Feb 13, 2021 •
edited
Loading

Contains the necessary changes to let us compile on GHC 8.10.4

Builds on #3943.

Don't worry about merging this anytime soon, I'm just making sure we don't fall too far behind. Maybe the next person comes along and makes a GHC9 PR on top of this one.

@kritzcreek kritzcreek changed the title Updates for GHC 8.10.3 Updates for GHC 8.10.4 Feb 13, 2021
@kritzcreek
Copy link
Copy Markdown
Member Author

kritzcreek commented Feb 13, 2021

Interestingly enough it's the Linux build that fails on Travis:

$ stack --no-terminal setup

<<<<<<<<<<<<<<<<<<

You are currently using Stack version 2.1.1, but version 2.5.1.1 is available

You can try to upgrade by running 'stack upgrade'

Tired of seeing this? Add 'recommend-stack-upgrade: false' to /home/travis/.stack/config.yaml

>>>>>>>>>>>>>>>>>>

Stack has not been tested with GHC versions above 8.6, and using 8.10.4, this may fail

Preparing to install GHC to an isolated location.

This will not interfere with any system-level installation.

Preparing to download ghc-8.10.4 ...

ghc-8.10.4: download has begun

ghc-8.10.4:   86.47 MiB / 206.44 MiB ( 41.89%) downloaded...

ghc-8.10.4:  194.96 MiB / 206.44 MiB ( 94.44%) downloaded...

ghc-8.10.4:  206.44 MiB / 206.44 MiB (100.00%) downloaded...

Downloaded ghc-8.10.4.

Unpacking GHC into /home/travis/.stack/programs/x86_64-linux/ghc-8.10.4.temp/ ...

Received ExitFailure (-15) when running

Raw command: /bin/tar Jxf /home/travis/.stack/programs/x86_64-linux/ghc-8.10.4.tar.xz

Run from: /home/travis/.stack/programs/x86_64-linux/ghc-8.10.4.temp/

Error: Error encountered while unpacking GHC with

         tar Jxf /home/travis/.stack/programs/x86_64-linux/ghc-8.10.4.tar.xz

         run in /home/travis/.stack/programs/x86_64-linux/ghc-8.10.4.temp/

       

       The following directories may now contain files, but won't be used by stack:

         - /home/travis/.stack/programs/x86_64-linux/ghc-8.10.4.temp/

         - /home/travis/.stack/programs/x86_64-linux/ghc-8.10.4/

       

       For more information consider rerunning with --verbose flag

       

The command "stack --no-terminal setup" failed and exited with 1 during .

I think it's possible we'd have to just update the used stack version on CI here.

rhendric added 2 commits March 18, 2021 20:36
@rhendric
Merge remote-tracking branch 'purescript/master' into HEAD
a8e978a
@rhendric
Let's try bionic
01e0ad0 
Also let's try actually noticing and obeying the new instructions for
updating version constraints in purescript.cabal.
@rhendric
Copy link
Copy Markdown
Member

rhendric commented Mar 19, 2021 •
edited
Loading

Now that @hdgarrood merged #3933, I took the liberty of merging master into this PR, rather than create yet another one, and giving the versions another little bump. (I didn't touch any code.)

The top-level summary is:

  • Stackage resolver upgraded from lts-13.26 to lts-17.6
  • Stack on build machines upgraded from 2.1.1 to 2.5.1
  • Linux build machine upgraded from trusty to bionic (this was motivated by an issue with compiling a newer version of cryptonite with GCC <4.9)

hdgarrood
hdgarrood approved these changes Mar 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@kritzcreek kritzcreek marked this pull request as ready for review March 20, 2021 10:14
@hdgarrood hdgarrood mentioned this pull request Mar 20, 2021
Closed
3 tasks
@hdgarrood hdgarrood merged commit ee0b3d3 into purescript:master Mar 20, 2021
@kritzcreek kritzcreek deleted the ghc-8.10.3 branch March 20, 2021 18:06
@jvliwanag jvliwanag mentioned this pull request Mar 21, 2021
Closed
@kl0tl kl0tl mentioned this pull request Apr 3, 2021
Merged
4 tasks
@JordanMartinez JordanMartinez mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hdgarrood hdgarrood hdgarrood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kritzcreek @rhendric @hdgarrood