Skip to content

Update to GHC 8.8.4#3943

Closed
TheMatten wants to merge 1 commit intopurescript:masterfrom
TheMatten:ghc-8.8.4
Closed

Update to GHC 8.8.4#3943
TheMatten wants to merge 1 commit intopurescript:masterfrom
TheMatten:ghc-8.8.4

Conversation

@TheMatten
Copy link
Copy Markdown

Bumps snapshot, upper bounds and fixes (little amount of) breakage introduced by new versions of libraries. In case of lib/purescript-cst/tests/TestCst.hs, I've replaced use of fail with error, because new version of Gen doesn't seem to provide MonadFail or some other error reporting functionality (it seems like old Monad.fail deferred to default implementation anyway).

  • stack build works
  • stack run works
  • stack test passes

(To add some motivation, I'm trying to build purescript with asterius which is currently on 8.8.4)

@hdgarrood
Copy link
Copy Markdown
Contributor

Thanks for the PR. Just so you know, this is unlikely to get looked at until at least v0.14.0 is out and #3933 is merged - I'd really like to get #3933 in before we start fiddling with version bounds, because otherwise it will need redoing.

@mitchblank
Copy link
Copy Markdown

Any updates now that 0.14.0 is out?

@hdgarrood
Copy link
Copy Markdown
Contributor

I still want to get #3933 merged first.

@waynevanson
Copy link
Copy Markdown

She's merged! Looking forward to see this come to fruition.

@hdgarrood
Copy link
Copy Markdown
Contributor

We are probably going to merge #4013 instead, as it happens.

@hdgarrood
Copy link
Copy Markdown
Contributor

I’m going to close this as we are on 8.10.4 as of merging #4013. Thanks anyway for the PR!

@hdgarrood hdgarrood closed this Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants