Conversation
The rc1 I already tagged is no good, because I forgot to update the version. That is particularly important for this release, because tools like psa need to be able to know what version of the CLI they have encountered in order to know whether to read from stdout or stderr if they want to maintain compatibility with both 0.13.x and 0.14.x.
natefaubion
reviewed
Sep 16, 2020
| -- prerelease identifier here (if any). When releasing a proper version, simply | ||
| -- set this to an empty string. | ||
| prerelease :: String | ||
| prerelease = "-rc2" |
Contributor
There was a problem hiding this comment.
Is the pre-release identifier necessary if we don't intend to publish it to Hackage?
Contributor
There was a problem hiding this comment.
I suppose this is useful for debugging purposes. You do not want someone thinking they have the proper release, when they still have an rc.
natefaubion
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rc1 I already tagged is no good, because I forgot to update the
version. That is particularly important for this release, because tools
like psa need to be able to know what version of the CLI they have
encountered in order to know whether to read from stdout or stderr if
they want to maintain compatibility with both 0.13.x and 0.14.x.