Skip to content

Recurse on the right of arrows and under foralls when inferring nominal roles from kinds#3896

Merged
hdgarrood merged 3 commits intopurescript:masterfrom
kl0tl:fix-issue-3895
Jun 4, 2020
Merged

Recurse on the right of arrows and under foralls when inferring nominal roles from kinds#3896
hdgarrood merged 3 commits intopurescript:masterfrom
kl0tl:fix-issue-3895

Conversation

@kl0tl
Copy link
Copy Markdown
Member

@kl0tl kl0tl commented Jun 3, 2020

Fix #3895.

@hdgarrood
Copy link
Copy Markdown
Contributor

This looks good but I do quite like the formulation in terms of kindArity as in #3893. Could you put kindArity in this commit? Then rolesFromForeignTypeKind would just be \k -> replicate (kindArity k) Nominal right?

Copy link
Copy Markdown
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hdgarrood hdgarrood merged commit fe57d49 into purescript:master Jun 4, 2020
@kl0tl kl0tl deleted the fix-issue-3895 branch June 4, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Role inference for foreign imported types without roles declaration is wrong

3 participants