Represent class dictionaries as data types#3567
Represent class dictionaries as data types#3567garyb wants to merge 1 commit intopurescript:masterfrom
Conversation
|
Do you think we should try to get #3381 merged before or after this? |
|
I'm fine with it either way - there should be no conflicts if that goes in first though, whereas if I do something in here there probably will be something to resolve. This PR will probably be on hold for a couple of days anyway, I was talking to Christoph about some stuff to do with externs, so I'm probably going to make a PR changing some things there before coming back to this (it's also relevant to this PR - should help fix the IDE failure case). |
|
I'll try and bash this back into shape. I got sucked down a wormhole when I started tinkering with the externs and lost sight of the primary goal, then life happened, etc. Making the externs carry just what is necessary (rather than including additional compiler generated stuff that could instead be regenerated on load) will be a fairly decent chunk of work on its own I think. |
|
Should this be closed in favor of #4125? |
3 participants
Resolves #781
The typechecking aspect of this works perfectly now, since #3128 (... that was Oct 2017? 😱 I thought it was fairly recent)
There are two failing tests that shouldn't be too hard to fix:
And there are two TODOs
desugarTypeClassesAccessor, as that assumes the implementation of types is record-like in the codegen target