Error message for cyclic type class#3381
Error message for cyclic type class#3381natefaubion merged 5 commits intopurescript:masterfrom saskliutas:master
Conversation
|
Thanks for the PR, and sorry this went so long unacknowledged! This looks good, but I think we can improve the error a little more still. We should be able to always include information about the names of the relevant classes, I think. Presumably if we get an In the case where we have more than one class in the SCC, I think it would be better to print something like where If you're unlikely to pick this up again (which is totally understandable at this point) I'd appreciate it if you could let us know so that someone else can. |
|
@hdgarrood Thanks for your response. I have made changes as you suggested. |
hdgarrood
left a comment
There was a problem hiding this comment.
Looks good - just one more thing I've noticed and then I think this is good to merge. Also could you please add yourself to CONTRIBUTORS.md?
hdgarrood
left a comment
There was a problem hiding this comment.
Thanks! The CI failure on AppVeyor isn't anything to do with your code, and it's passing on Travis, so I think we can just ignore it for now.
Made an attempt on #3223. Added check for cycles before desugaring type class declarations, now correct error message is shown.
Error message after changes: