Add missing output directory to error#3311
Merged
kritzcreek merged 3 commits intopurescript:masterfrom Apr 19, 2018
Merged
Conversation
Member
|
Please add yourself to the CONTRIBUTORS.md file. |
kritzcreek
requested changes
Apr 19, 2018
Member
kritzcreek
left a comment
kritzcreek
left a comment
There was a problem hiding this comment.
Thanks, just a few comments
src/Language/PureScript/Ide.hs
Outdated
| oDir <- outputDirectory | ||
| unlessM (liftIO (doesDirectoryExist oDir)) | ||
| (throwError (GeneralError "Couldn't locate your output directory.")) | ||
| (throwError (GeneralError $ "Couldn't locate your output directory: " <> (toS oDir) <> ".")) |
Member
There was a problem hiding this comment.
What do you think of Couldn't locate your output directory at: ...? Makes it a little clearer that we went searching for it.
Could we run the path through System.FilePath.normalise and use an explicit T.pack over toS? I also think we should leave off the trailing . since it'll be in the way when copy pasting the path.
Member
|
Great, thanks! |
kritzcreek
approved these changes
Apr 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.