Complete after parens and brackets in REPL#3236
Merged
kritzcreek merged 3 commits intopurescript:masterfrom Mar 22, 2018
rndnoise:fix-complete-after-parens-and-brackets-in-repl
Merged
Complete after parens and brackets in REPL#3236kritzcreek merged 3 commits intopurescript:masterfrom rndnoise:fix-complete-after-parens-and-brackets-in-repl
kritzcreek merged 3 commits intopurescript:masterfrom
rndnoise:fix-complete-after-parens-and-brackets-in-repl
Conversation
- Complete all names that have been imported (transitively or directly) - Do not complete names that haven't been imported - Only recompute list of names after import or adding a let binding rather than after each request for name completion This commit fixes #3227
Member
|
This might need a rebase after I merged the unit test PR |
…r-parens-and-brackets-in-repl
kritzcreek
approved these changes
Mar 22, 2018
Member
|
I'd like to make an effort to get all of these PSCI improvements merged. We have pretty good tests coverage and as long as we keep all the tests happy I think we can't go too far astray. @rndnoise Sorry for the long wait.... We only do "Squash and merge" on this repo so you might need to rebase the subsequent PRs whenever I merge one of these "chain" PRs. |
Contributor
Author
|
No problem, I realize it's a lot of work to review changes (often more work than it is to contribute a PR). I don't mind rebasing -- let me know if I've used git in a way that causes extra work for you so I can avoid doing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the REPL where names aren't completed directly after
[or(, like when you've typedx = [and hit Tab. This depends on #3231 being merged, not because of the implementation, but because of the changes in unit tests.