Add source spans to name constructors and fix ShadowedName warning#3213
Merged
garyb merged 1 commit intopurescript:masterfrom Jan 21, 2018
Merged
Add source spans to name constructors and fix ShadowedName warning#3213garyb merged 1 commit intopurescript:masterfrom
ShadowedName warning#3213garyb merged 1 commit intopurescript:masterfrom
Conversation
Member
Author
|
Oh, this also has #3212 in it, can either close that or merge it first or whatever. |
kritzcreek
approved these changes
Jan 21, 2018
Member
kritzcreek
left a comment
kritzcreek
left a comment
There was a problem hiding this comment.
I've read it twice and didn't find any problems so 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3208