Conversation
hdgarrood
force-pushed
the
revert-proxies
branch
from
941e349 to
517dbb2
Compare
| import Data.Symbol (SProxy(..)) | ||
|
|
||
| class Same l r (o :: Symbol) | l r -> o | ||
| instance sameY :: Same t t "Y" else instance sameN :: Same l r "N" |
There was a problem hiding this comment.
@LiamGoodacre I've changed this class slightly, so that the o parameter is a Symbol rather than a proxy, just because that seemed to make it slightly simpler. I did the same in the other failing instance chains test as well. Do you think this makes sense?
|
The CI failure is only on the Haddock build and it's to do with a timeout so I'm going to ignore it. I just checked and the core libraries all still compile with this code, apart from |
kritzcreek
left a comment
kritzcreek
left a comment
There was a problem hiding this comment.
Looks good! I've restarted the Travis Job that failed.
|
Unfortunately if you restart a job, it seems to pick up the cache as it was at the start of the first attempt, which means it will most likely fail for the same reason again (ie timeout installing dependencies). I should really have just pushed an empty commit - that way you get to pick up where the previous build left off. |
|
Ok never mind then! |
|
Thank you! |
* Revert "pretty print proxy types when rendering docs (purescript#3144)" This reverts commit 14227c7. * Revert "Print proxy type as an operator (purescript#3124)" This reverts commit cfd1db3. * Revert "Fix proxies: synonyms, inference, traversals, instances (purescript#3095)" This reverts commit fe0aa0d. * Revert "Add proxies (purescript#2846)" This reverts commit 74bc4a9. * Remove one last occurrence of the ProxyType constructor * Update tests to not use new proxies
3 participants
Resolves #3178. I've reverted the commits from the following PRs, in reverse chronological order:
After this is merged I will delete the
0.12.0-devbranch (unless anyone objects, but I don't see a reason to now, since everything in that branch is now also inmaster).Still WIP: I need to fix the tests and check the core libraries still compile.