Only add newline before initial group of comment lines in codegen#3098
Merged
paf31 merged 1 commit intopurescript:masterfrom Oct 1, 2017
Merged
Conversation
paf31
pushed a commit
that referenced
this pull request
Nov 8, 2017
jutaro
pushed a commit
to mgmeier/purescript
that referenced
this pull request
Mar 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3096.
Most Purescript code tends to be commented using multiple Line comments rather than block comments. This change removes the current behaviour of adding additional newlines between each line comment, producing more readable javascript comments when compiling with comments.
I am not really sure how to implement a test for this change?