Fixing some issues with proxies#3095
Merged
LiamGoodacre merged 1 commit intopurescript:masterfrom Oct 1, 2017
LiamGoodacre:fix/proxies
Merged
Fixing some issues with proxies#3095LiamGoodacre merged 1 commit intopurescript:masterfrom LiamGoodacre:fix/proxies
LiamGoodacre merged 1 commit intopurescript:masterfrom
LiamGoodacre:fix/proxies
Conversation
paf31
reviewed
Sep 26, 2017
| subsumes' mode ty1 ty2 | ||
| subsumes' mode ty1 (KindedType ty2 _) = | ||
| subsumes' mode ty1 ty2 | ||
| subsumes' mode (ProxyType ty1) (ProxyType ty2) = |
Contributor
There was a problem hiding this comment.
We shouldn't have proxies for polymorphic things, so I don't know why we need this. In any case, I don't think it's true that Proxy is necessarily covariant.
paf31
reviewed
Sep 26, 2017
| check' (PositionedValue pos c val) ty = warnAndRethrowWithPositionTC pos $ do | ||
| TypedValue t v ty' <- check' val ty | ||
| return $ TypedValue t (PositionedValue pos c v) ty' | ||
| check' p@(Proxy ty1) ty2 = do |
Contributor
There was a problem hiding this comment.
I don't think we need this case. Falling through to infer should work.
Contributor
|
Looks good! Do we skolemize the type under the Edit: just checked, yes we do. |
Member
Author
|
@paf31, thanks for reviewing so quickly. I was sure there'd be some redundant changes - I changed lots of stuff until it worked and hadn't worked out which bits actually mattered. |
LiamGoodacre
changed the title
hdgarrood
added a commit
that referenced
this pull request
Dec 30, 2017
This reverts commit fe0aa0d.
Merged
hdgarrood
added a commit
that referenced
this pull request
Jan 3, 2018
* Revert "pretty print proxy types when rendering docs (#3144)" This reverts commit 14227c7. * Revert "Print proxy type as an operator (#3124)" This reverts commit cfd1db3. * Revert "Fix proxies: synonyms, inference, traversals, instances (#3095)" This reverts commit fe0aa0d. * Revert "Add proxies (#2846)" This reverts commit 74bc4a9. * Remove one last occurrence of the ProxyType constructor * Update tests to not use new proxies
matthewleon
pushed a commit
to matthewleon/purescript
that referenced
this pull request
Jan 6, 2018
* Revert "pretty print proxy types when rendering docs (purescript#3144)" This reverts commit 14227c7. * Revert "Print proxy type as an operator (purescript#3124)" This reverts commit cfd1db3. * Revert "Fix proxies: synonyms, inference, traversals, instances (purescript#3095)" This reverts commit fe0aa0d. * Revert "Add proxies (purescript#2846)" This reverts commit 74bc4a9. * Remove one last occurrence of the ProxyType constructor * Update tests to not use new proxies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3072