Conversation
kritzcreek
force-pushed
the
bump-to-ghc8-2
branch
from
ac93db9 to
7fc5d33
Compare
|
I would definitely advocate putting together a project-specific Prelude and dropping the protolude dependency, even. I'm less keen on Protolude now since it's caused build issues, because it defines its own Bifunctor despite the perfectly good existing one in bifunctors, and also because of the new string conversion stuff, as some of the implicit conversions it can do are a bit dodgy. I think we could very easily maintain our own custom Prelude inside this repo instead. |
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Do you know if there will be an LTS soon?
|
If you push an empty commit, that should help stop the builds from timing out. |
|
Looks good to me, thanks Christoph! I'd be fine with a (minimal) custom prelude module. |
|
Do the Travis failures block this from being merged? |
|
@ilovezfs I just pushed an empty commit with the hope of making the tests succeed (switching GHC versions requires too much dependency compilation to do it in one travis build). If things succeed I'd be happy to merge this, and we can talk about the minimal Prelude in another issue/PR. |
|
Something's broken with the OSX CI instances, but @Cmdv tested that things build fine on OSX for me. Should we merge this despite the CI failures? |
|
👍 Let's merge and fix up CI later. |
* fixes cabal warning about an unspecified Paths module * Bump to GHC 8.2 stack nightly * trigger rebuild * fix more shadowing warnings * retrigger build * try again
4 participants
Fixes #3065
I bumped the resolver to point at the current nightly, and relaxed all the blocking bounds. I also checked the changelogs and didn't find anything that directly affects us. I'd totally encourage someone else to do the same though.
I haven't paid attention to retaining backwards compatibility with GHC 8.0.2. I don't really like that Protolude exports
moduleNamenow, and I'm wondering if it would be a good idea to build our own project specific Prelude. We could still use protolude as a baseline, but a lot of the exported names from the Generics modules conflict with things a in compiler project.