Require single-method instance declarations to be indented#2965
Require single-method instance declarations to be indented#2965paf31 merged 2 commits intopurescript:masterfrom
Conversation
LiamGoodacre
left a comment
LiamGoodacre
left a comment
There was a problem hiding this comment.
Looks good. I believe purescript.cabal also wants updating to refer to the new example files. I think it updates automatically when you run the tests.
|
Thanks for the swift review. Looks like |
|
Oh interesting, thanks! |
|
I don't think this previously would have required a cabal file change anyway, it used to be only when you added a directory that you would need to change it, since the globbing in cabal files doesn't allow any kind of recursive includes like |
|
Thanks! Please update CONTRIBUTORS.md as well and I'll get this merged in. |
|
Thanks! |
|
Unfortunately, this is a breaking change, since the compiler no longer allows code like this, which occurs quite frequently: instance foo :: Foo String where
instance bar :: Bar String where
member = ...Note how I'll revert this, but we can try to include it in the next breaking release or find a way to make it non-breaking. |
…2985) * Revert "Fix child decl ordering (#2984)" This reverts commit 7fdd39d. * Revert "Only build master and semver tags in Travis (#2982)" This reverts commit c41a7a4. * Revert "Include comments in child declarations in HTML docs (#2981)" This reverts commit ad6166f. * Revert "Solve RowToList (#2945)" This reverts commit 0e2d820. * Revert "Fix links to type operators in HTML docs (#2979)" This reverts commit 5fe26f2. * Revert "Re-evaluate REPL globs during :reload (#2978)" This reverts commit 50e1c68. * Revert "[purs ide] Collect data constructors (#2976)" This reverts commit c965f35. * Revert "Replace synonyms in instance constraints (#2973)" This reverts commit ee66e0d. * Revert "Require single-method instance declarations to be indented (#2965)" This reverts commit b3e470d.
|
@quesebifurcan Would you like to reopen this now that we're putting 0.12.0 together? Thanks! |
|
@paf31 Sure, I'll see if I can come up with something (preferably non-breaking) over the weekend. If not, I'm happy to let someone else take over. |
|
Oh it's fine to break now, we're at a major release. You could just reopen the PR if you like. |
4 participants
Resolves #2947