Allow things to be hidden from Prim#2951
Conversation
purescript.cabal
Outdated
| test-suite tests | ||
| build-depends: | ||
| aeson >=1.0 && <1.2 | ||
| aeson >=1.0 && <1.1 |
There was a problem hiding this comment.
Hmm, looks like that PR that went in changed this instead of the package.yaml. Maybe this should be removed from and gitignored in the repo now, if we're relying on hpack?
There was a problem hiding this comment.
I think we need both if we want Cabal users to be able to build things.
There was a problem hiding this comment.
Yes, this has happened too many times now; I think we do need to either gitignore the cabal file or stop using hpack. I'm not particularly attached to one option over the other but if it was solely up to me I'd probably go for stopping using hpack.
There was a problem hiding this comment.
I'd be fine with not using hpack.
|
For the record, when digging into this I discovered the environment was being initialized for every module as if it had these imports regardless of what the user was doing. Now it allows these imports to be rewritten if they are specifically included. It's not great that it needs importing with and without qualification, but I have an idea about how to fix that as part of the fix for #1647 too. It's currenty necessary to have it qualified as generated names (like when {} is desugared into |
|
Can you explain a little more why we need both imports, maybe by giving an example? I'm not seeing it. |
type Test = {}is desugared into type Test = Prim.Record ()With no |
|
I assume this is to do with the order in which the various desugaring steps happen? Couldn't we just desugar it to |
Well, kinda. Desugaring isn't the right term I guess, since it comes directly out of the parser as
We could, but that only works if someone hasn't done |
Resolves #2499