[purs ide] Groups reexports in completions#2907
Merged
kritzcreek merged 6 commits intopurescript:masterfrom Jun 4, 2017
Merged
[purs ide] Groups reexports in completions#2907kritzcreek merged 6 commits intopurescript:masterfrom
kritzcreek merged 6 commits intopurescript:masterfrom
Conversation
Contributor
|
Adding where the identifier comes from to the output would allow to filter results (or group them) at the editor level. |
kritzcreek
force-pushed
the
psc-ide-group-reexports
branch
from
0277647 to
352bd2d
Compare
kritzcreek
changed the title
Member
Author
|
This is ready for review/discussion about API and whether this should become the default behaviour. I kept the documentation somewhat brief, but I'll happily explain in more detail if something is unclear. /cc @nwolverson @coot @FrigoEU |
kritzcreek
force-pushed
the
psc-ide-group-reexports
branch
from
3e700a8 to
8f80f06
Compare
nwolverson
reviewed
May 29, 2017
psc-ide/PROTOCOL.md
Outdated
| "currentModule": "Main", | ||
| "options": { | ||
| "maxResults": 50 | ||
| "groupReexports": ["Prelude", "Data.Array", "Data.List"] |
Contributor
There was a problem hiding this comment.
Is this outdated, having been switched to a boolean?
Adds an option to control how reexport should be grouped in the completions.
If the groupReexports flag is set, we just treat every export as a reexport (Even from the origin module). This will require the editors to do a little more work, but makes the behaviours consistent and predictable.
kritzcreek
force-pushed
the
psc-ide-group-reexports
branch
from
e772122 to
a97a5b2
Compare
paf31
approved these changes
Jun 3, 2017
Member
Author
|
I'll merge this in for the upcoming release, since it's non-breaking. If I decide I don't like the API I'll change it again in the next breaking release. Please give feedback on whether this is useful if you happen to use it in your editor plugins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to control how reexport should be grouped in the completions.
TODO:
Fixes #2752, Fixes #2908