publish: Allow for older git versions#2673
Merged
paf31 merged 2 commits intopurescript:masterfrom Feb 18, 2017
Merged
Conversation
Contributor
|
Thanks, but please also update CONTRIBUTORS.md. |
Add @mcoffin (Matt Coffin) [ci skip]
Contributor
Author
|
@paf31 Done. My bad. That's what I get for only skimming the contributing guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not adding any tests per same reasoning as #2613.
Currently, git versions < 2.2 will fail with
psc-publishbecause they don't have theiso-strictdate format available. Since we're just parsing in to unix time anyway, we can easily have git just output the unix timestamp in epoch seconds and parse that instead, ensuring compatibility with older git versions (most notably the one currently used by travis-ci).EDIT: Some discussion also happened in #2610