Conversation
|
Nice! |
|
Does this look ok to merge? |
|
I think so... I didn't see anything wrong in the code, but my review was pretty superficial. The new errors look awesome! Does the package set / Halogen, etc. still compile? |
|
I tested Halogen but not the whole package set. Let me see ... |
|
If Halogen passes it's probably fine, it's probably one of the harder tests due to the great deal of existentials 😄. I guess maybe lensy things would be the only other thing potentially tripped up by it? |
|
Well Thermite is okay too, which uses lenses quite a bit. But I'll test the package set anyway. All 148 packages is probably a pretty thorough test :) |
|
@garyb Everything builds, except for The error is this: and you can fix it by inserting a few |
|
Yeah, I think we have a bunch of breaking changes in the core libs queued up, so makes sense to do that with 0.11 :) |
|
Oh, if it doesn't need a breaking change, but just a fix before this goes out - even better. |
Fixes #2567 and #2310.
Here is an example of the new error message: