Merged
Conversation
paf31
approved these changes
Feb 8, 2017
Contributor
Author
|
Argh, one of these days I'm going to remember to wait for CI to finish first. |
Contributor
Author
|
Thanks! I was planning to point directly to this commit in |
Member
|
We probably need a .7 soon anyway: #2642 |
Contributor
Author
|
Argh, that's my fault too, sorry! |
paf31
pushed a commit
that referenced
this pull request
Feb 11, 2017
* Add tests for links to Prim declarations * Fix links to Prim declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, links to Prim declarations are still broken on Pursuit; I guess this bug sneaked in while I was transferring this code to this repo. I've fixed it again (and verified that it fixes the issue in Pursuit) and also added a test.