Remove extra-deps from stack-ghc-8.0.yaml#2636
Merged
paf31 merged 1 commit intopurescript:masterfrom Feb 8, 2017
hatashiro:stack-ghc-8-extra
Merged
Remove extra-deps from stack-ghc-8.0.yaml#2636paf31 merged 1 commit intopurescript:masterfrom hatashiro:stack-ghc-8-extra
paf31 merged 1 commit intopurescript:masterfrom
hatashiro:stack-ghc-8-extra
Conversation
kritzcreek
reviewed
Feb 8, 2017
purescript.cabal
Outdated
| parsec >=3.1.10, | ||
| pattern-arrows >= 0.0.2 && < 0.1, | ||
| pipes >= 4.0.0 && < 4.3.0, | ||
| pipes >= 4.0.0 && < 4.3.3, |
Member
There was a problem hiding this comment.
< 4.4.0 might make more sense, since I don't expect breaking changes on a patch release.
purescript.cabal
Outdated
| Glob >= 0.7 && < 0.8, | ||
| haskeline >= 0.7.0.0, | ||
| http-client >= 0.4.30 && <0.5, | ||
| http-client >= 0.4.30 && < 0.5.6, |
Member
There was a problem hiding this comment.
< 0.6.0 might make more sense, since I don't expect breaking changes on a patch release.
| build-depends: base >=4 && <5, | ||
| purescript -any, | ||
| aeson >= 0.8 && < 1.0, | ||
| aeson >= 0.8 && < 1.1, |
purescript.cabal
Outdated
| wai-websockets == 3.*, | ||
| warp == 3.*, | ||
| websockets >= 0.9 && <0.10 | ||
| websockets >= 0.9 && < 0.10.1 |
purescript.cabal
Outdated
| build-depends: base >=4 && <5, | ||
| purescript -any, | ||
| aeson >= 0.8 && < 1.0, | ||
| aeson >= 0.8 && < 1.1, |
purescript.cabal
Outdated
| purescript -any, | ||
| directory -any, | ||
| aeson >= 0.8 && < 1.0, | ||
| aeson >= 0.8 && < 1.1, |
purescript.cabal
Outdated
| other-extensions: | ||
| build-depends: base >=4 && <5, | ||
| aeson >= 0.8 && < 1.0, | ||
| aeson >= 0.8 && < 1.1, |
Contributor
Author
|
Thanks for the comments! I will rebase this after #2632 is merged. |
To use the packages in the resolver, version constraints in the cabal file is loosened. Also Pursuit.hs is modified to support the higher version of http-client, without behaviour change.
Contributor
Author
|
I have rebased the patch with #2632. |
hdgarrood
approved these changes
Feb 8, 2017
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use the packages in the resolver, version constraints in the cabal file is loosened. Also Pursuit.hs is modified to support the higher version of http-client, without behaviour change.
I've built and tested with both
stack.yamlandstack-ghc-8.0.yaml, and there was no problem.