Conversation
|
Looking good! I've pr'd #2634 against this branch to fix the test failures. We said we wanted to provide wrappers around the consolidated executable to smoothen the breakage or do we just go full burning bridges with 0.11? |
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Unfortunately github's mobile UI isn't good enough for me to be able to give this a proper review so I've only glanced over it so far. It does look good though.
| , optionsSourceMaps :: Bool | ||
| -- | | ||
| -- Dump CoreFn | ||
| -- ^ Generate soure maps |
|
Perhaps we could provide shell scripts named after the old executables for backwards compatibility in the binary bundles, just for the 0.11 series? They'd only need to be a few lines I think. For true backwards compat we would also need to have |
| infoModList :: Opts.InfoMod a | ||
| infoModList = Opts.fullDesc <> footerInfo where | ||
| footerInfo = Opts.footerDoc $ Just $ PP.vcat | ||
| [ examples, PP.empty, PP.text ("psc-docs " ++ showVersion Paths.version) ] |
There was a problem hiding this comment.
Oh wait, should we remove this reference to psc-docs?
| version :: Parser (a -> a) | ||
| version = abortOption (InfoMsg (showVersion Paths.version)) $ long "version" <> help "Show the version number" <> hidden | ||
| command :: Opts.Parser (IO ()) | ||
| command = compile <$> (version <*> Opts.helper <*> pscMakeOptions) where |
There was a problem hiding this comment.
I'm not sure the sub commands need to be able to respond to --version. Having psc --version work is enough IMO, we don't also need to support psc build --version etc.
* fix test failure and cabal warning * add missing files to cabal file
|
I'll fix the remaining bits on the other branch, after merging this. I also need to update the bundle script. |
* Remove psc-package * Single consolidated executable (#2633) * Single consolidated executable #2336 * PSCi * bundle * docs * hierarchy * publish * ide * Remove some old options, fix #2618 * Fix warning * fix test failure and cabal warning (#2634) * fix test failure and cabal warning * add missing files to cabal file * Various * Fix tests again
|
I just checked and it seems like |
|
@kritzcreek Sounds good, we can add it back. |
3 participants
Fixes #2336. This also removes
psc-ide-client, which had been discussed previously.