Fix failure to parse git tag date in psc-publish#2613
Merged
Conversation
Fixes one of the problems mentioned in #2610.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one of the problems mentioned in #2610. I've tested this with the repository that @owickstrom used to demonstrate the issue originally. I'd like to restructure the tests so that they're able to catch this sort of error but unfortunately that's going to be a bit more involved, as
psc-publishis currently tested via the purescript library but really we should be testing it via its CLI, I think. So I'd rather just do this for now and save that for later.